[DNM][Do Not Review][Demo Only] LMDK 006 demo #8296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 45c9f2f. It interferes with the pointer-style loadable module infrastructure. Signed-off-by: Guennadi Liakhovetski <[email protected]>
[[ [TEST VERSION] duplicated include/ files will be removed on upstream ]] This will add module example lib with up down mixer module as a simple example Signed-off-by: Adrian Bonislawski <[email protected]> Co-authored-by: Dobrowolski, PawelX <[email protected]>
Signed-off-by: Chao Song <[email protected]>
It now compiles but still doesn't link because of multiple missing symbols. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Now only gcd(), comp_verify_params() and data blob functions are still missing. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Add the missing methods to build the smart-amp loadable module test. Signed-off-by: Guennadi Liakhovetski <[email protected]>
This now compiles, but will probably crash because of a wrong .process*() method. Signed-off-by: Guennadi Liakhovetski <[email protected]>
To test smart-amp-test as a loadable module it shouldn't be built into the firmware image. Signed-off-by: Guennadi Liakhovetski <[email protected]>
struct comp_ipc_config now has an additional member: uint32_t proc_domain Signed-off-by: Guennadi Liakhovetski <[email protected]>
Loadable modules are linked, using a linked script, built by a cmake script. That linker script includes multiple existing linker script fragments. Each of those fragments defines 1 or more sections and respective PHDRs. However, some of those scripts, e.g. common_rodata_linker_script.txt and data_linker_script.txt add sections to the same rodata_phdr PHDR. This makes the linker allocate sections in that PHDR twice in the resulting output file: one copy is real and the other one is filled with zeros. Removing one of the PHDR definitions solves the problem and removes about 60KiB of empty space from the output file. Signed-off-by: Guennadi Liakhovetski <[email protected]>
The module-adapter API has 3 processing modes: raw, stream and source-sink, and until now only one of them can be implemented by any module. However, the "modules" module, that loads loadable modules, has to implement all of them to be prepared to handle any loadable modules. This adds support for such modules. Signed-off-by: Guennadi Liakhovetski <[email protected]>
The loadable module API needs to support all module-adapter methods, add all the missing ones. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Update headers and prototypes to the current tip of the mtl-006-drop-stable branch. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Loadable modules use the system service pointer to call exported base firmware methods. Signed-off-by: Guennadi Liakhovetski <[email protected]>
|
@RDharageswari @mengdonglin @aiChaoSONG fyi. |
|
@mwasko fyi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only a partial demonstration of the "development kit" loadable module approach, ported on top of mtl-007-drop-stable. The example smart-amp-test, built from the lmdk/ directory can be loaded, it initialises, but further behaviour breaks either during preparation or when copying. A possible reason would be some further headers that need to be updated. Frequently changing headers make maintaining the "development kit" difficult and absence of logging from the modules make debugging complicated