Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topology1: Use DYNAMIC for ADL and RPL topologies #8230

Merged

Conversation

Vamshigopal
Copy link
Contributor

use dynamic for all the adl and rpl topologies except 3p(waves,DTS), excluded Dell sdw topologies which are not tested.

use dynamic for all the adl and rpl topologies except 3p(waves,DTS),
excluded Dell sdw topologies which are not tested.

Signed-off-by: Vamshi Krishna Gopal <[email protected]>
@Vamshigopal
Copy link
Contributor Author

This PR is same as #8093 in main, direct cherry-pick had conflicts , so pushed the patch without cherry-pick.

@marc-hb

This comment was marked as off-topic.

@marc-hb

This comment was marked as off-topic.

@marc-hb
Copy link
Collaborator

marc-hb commented Sep 19, 2023

Sorry I just realized this was submitted to obsolete branch cavs2.5-001-drop-stable

That explains all the CI failures, I'll stop looking at them. stable-v2.2 is fine in #8229

I really wish Github would highlight the target branch more, this gets me every time.

@johnylin76
Copy link
Contributor

Sorry I just realized this was submitted to obsolete branch cavs2.5-001-drop-stable

That explains all the CI failures, I'll stop looking at them. stable-v2.2 is fine in #8229

I really wish Github would highlight the target branch more, this gets me every time.

Hi @marc-hb , do you mean we should stop cherry-picking any commit to cavs2,5-001-drop-stable since it's obsolete?

Thanks

@marc-hb
Copy link
Collaborator

marc-hb commented Sep 20, 2023

Hi @marc-hb , do you mean we should stop cherry-picking any commit to cavs2,5-001-drop-stable since it's obsolete?

I meant "obsolete" with respect to CI checks only, sorry for the confusion. I don't know what this branch is used for. Maybe it's very useful for something/someone.

@johnylin76
Copy link
Contributor

Hi @marc-hb , do you mean we should stop cherry-picking any commit to cavs2,5-001-drop-stable since it's obsolete?

I meant "obsolete" with respect to CI checks only, sorry for the confusion. I don't know what this branch is used for. Maybe it's very useful for something/someone.

Thanks for the quick response. Currently cavs2.5-001-drop-stable is the remote reference of the production branch for ChromeOS on Intel platforms.

@marc-hb
Copy link
Collaborator

marc-hb commented Sep 20, 2023

I think most CI checks could be fixed easily, just need to look at recent cherry-picks on stable-v2.2

@singalsu

This comment was marked as off-topic.

@lgirdwood
Copy link
Member

Thanks for the quick response. Currently cavs2.5-001-drop-stable is the remote reference of the production branch for ChromeOS on Intel platforms.

@johnylin76 Ack, this branch is very much active and in no way obsolete.

@mwasko fyi topology cherry-pick.

@mwasko mwasko merged commit 338ac57 into thesofproject:cavs2.5-001-drop-stable Sep 21, 2023
15 of 19 checks passed
@marc-hb
Copy link
Collaborator

marc-hb commented Sep 22, 2023

I think most CI checks could be fixed easily, just need to look at recent cherry-picks on stable-v2.2

Done, please review:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants