Audio: Fix the errors of dai timestamp ops #8192
Conversation
andrula-song
force-pushed
the
timestamp
branch
from
1d28105 to
1cbba44
Compare
src/audio/dai-zephyr.c
Outdated
| @@ -1669,7 +1669,7 @@ static int dai_copy(struct comp_dev *dev) | |||
| int dai_common_ts_config_op(struct dai_data *dd, struct comp_dev *dev) | |||
| { | |||
| struct ipc_config_dai *dai = &dd->ipc_config; | |||
| struct dai_ts_cfg cfg; | |||
| struct dai_ts_cfg *cfg = (struct dai_ts_cfg *)&dd->ts_config; | |||
There was a problem hiding this comment.
why do we actually have struct dai_ts_cfg identical to struct timestamp_cfg and struct dai_ts_data identical to struct timestamp_data?
There was a problem hiding this comment.
The content of both struct is the same, and the final function in zephyr/driver/dai/intel/ needs such input parameter.
There was a problem hiding this comment.
right, so would it be possible to drop struct timestamp_cfg and struct timestamp_data completely and use struct dai_ts_cfg and struct dai_ts_data instead everywhere?
EDIT: if we need those copies for XTOS, then we could call them the same as for Zephyr and put under #ifdef
There was a problem hiding this comment.
okay, then I would like to redefine the struct struct dai_data.
There was a problem hiding this comment.
yes, I think that would be good - and define copies of those structures in dai-legacy.h under #ifndef __ZEPHYR__
There was a problem hiding this comment.
but if we are using dai_legacy.c, we will use the original struct timestamp_cfg and struct timestamp_data(because the original interface without zephyr needs such input parameters). So I don't think it is good to redefine struct dai_data in dai-legacy.h in this PR.
There was a problem hiding this comment.
sure, we can rename them for legacy, right? And no, it doesn't have to be fixed in this PR
There was a problem hiding this comment.
then I'd like to use another PR to redefine for legacy, because I can not test it before I push code to PR right now.
use the ts_config of struct dai_data as input/output parameter instead a temporary variable while calling the dai timestamp functions. Signed-off-by: Andrula Song <[email protected]>
andrula-song
force-pushed
the
timestamp
branch
from
1cbba44 to
7b3c64b
Compare
Use struct dai_ts_data replace timestamp_data if CONFIG_ZEPHYR_NATIVE_DRIVERS is enabled. Signed-off-by: Andrula Song <[email protected]>
Use struct dai_ts_cfg replace timestamp_cfg of struct dai_data in dai-zephyr.h Signed-off-by: Andrula Song <[email protected]>
andrula-song
force-pushed
the
timestamp
branch
from
7b3c64b to
463fb93
Compare
andrula-song
requested review from
ranj063,
jxstelter,
RanderWang,
abonislawski,
pblaszko,
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
use the ts_config of struct dai_data as input/output parameter instead a temporary variable while calling the dai timestamp functions.