Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDC: fix message cache handling #8189

Merged
merged 1 commit into from
Sep 14, 2023
Merged

IDC: fix message cache handling #8189

merged 1 commit into from
Sep 14, 2023

Conversation

lyakh
Copy link
Collaborator

@lyakh lyakh commented Sep 12, 2023

When an IDC message is received from another core, the receiver core doesn't have any useful data for it in cache. Writing back the cache can corrupt the message data. Cache has to be invalidated instead.

lgirdwood
lgirdwood reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we spell out this flow with inline comments in sender and reciver. i.e. it needs to be obvious to the reader when we WB and when we INV. What about message payload ?

@lgirdwood
Copy link
Member

@mwasko @marcinszkudlinski fyi - for mtl-06

@lyakh
IDC: fix message cache handling
8f512c2 
When an IDC message is received from another core, the receiver core
doesn't have any useful data for it in cache. Writing back the cache
can corrupt the message data. Cache has to be invalidated instead.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
@lyakh
Copy link
Collaborator Author

lyakh commented Sep 13, 2023

Can we spell out this flow with inline comments in sender and reciver. i.e. it needs to be obvious to the reader when we WB and when we INV. What about message payload ?

@lgirdwood comments added

@lgirdwood
Copy link
Member

Known ZRESTRICT Zephyr issue reported. Unrelated.

@lgirdwood lgirdwood merged commit 832830a into thesofproject:main Sep 14, 2023
37 of 41 checks passed
@lyakh lyakh deleted the idc-cache branch September 15, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmleman tmleman tmleman approved these changes

@btian1 btian1 btian1 approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

@kv2019i kv2019i Awaiting requested review from kv2019i kv2019i is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lyakh @lgirdwood @btian1 @tmleman