[TEST] [Do not merge] Multiband-DRC test IPC4 switch control add control send #8168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The structs sof_ipc4_control_msg_payload and sof_ipc4_ctrl_value_chan match the similar structures in Linux kernel SOF IPC4 driver. Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch adds switch control handling into multiband_drc_set_config() operation. The switch control is a set large config with param_id set to SOF_IPC4_SWITCH_CONTROL_PARAM_ID. The patch changes config_id to param_id in this function. The config_id name was confusing. Signed-off-by: Seppo Ingalsuo <[email protected]>
The workaround is preserved but the comment is updated to describe why. Signed-off-by: Seppo Ingalsuo <[email protected]>
Testing 1 2 3 ... This just toggles the switch control state to user space. Leave alsamixer running and watch the control blink :) Signed-off-by: Seppo Ingalsuo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just a test for new kernel feature to update ALSA control from IPC4 firmware, during the playback the switch control blinks on/off while audio is streamed.
The contol update is in the last commit.