Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intel_adsp20: Enable LNL (ACE 2.0) platform in sof #7479
intel_adsp20: Enable LNL (ACE 2.0) platform in sof #7479
Changes from all commits
39f796e
c2e2b23
ab41814
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this too HDA specific? I'd say it should go in the driver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lyakh @jxstelter This is a bit iffy but we do have DAI type specific code for all vendors here and we need to convert from the IPC structs into language of the Zephyr driver interface (e.g. a single link_config field). At least in my initial review I checked that we need IPC4 structs the driver does not have access to.
@jxstelter Can you double-check could we calculate this in the driver? Direction and stream_id should be available already in driver code -- I guess depth and channel count should be available as well...?