module_adapter: modules: Remove unused sys_service pointer

The unused sys_service field has been removed from the processing_module structure. It was never initialized anywhere, and its value was passed as a parameter to the native_system_agent_start function which did not use it. Signed-off-by: Adrian Warecki <[email protected]>
thesofproject · Mar 21, 2024 · 67946ef · 67946ef
1 parent f2ad5d1
commit 67946ef
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 10 deletions.
diff --git a/src/audio/module_adapter/library/native_system_agent.c b/src/audio/module_adapter/library/native_system_agent.c
@@ -19,10 +19,8 @@ typedef void* (*native_create_instance_f)(void *mod_cfg, void *parent_ppl,
 
 struct native_system_agent native_sys_agent;
 
-void *native_system_agent_start(uint32_t *sys_service,
-				uint32_t entry_point, uint32_t module_id,
-				uint32_t instance_id, uint32_t core_id, uint32_t log_handle,
-				void *mod_cfg)
+void *native_system_agent_start(uint32_t entry_point, uint32_t module_id, uint32_t instance_id,
+				uint32_t core_id, uint32_t log_handle, void *mod_cfg)
 {
 	native_sys_agent.module_id = module_id;
 	native_sys_agent.instance_id = instance_id;

diff --git a/src/include/module/module/base.h b/src/include/module/module/base.h
@@ -180,9 +180,6 @@ struct processing_module {
 	 */
 	bool stream_copy_single_to_single;
 
-	/* pointer to system services for loadable modules */
-	uint32_t *sys_service;
-
 	/* total processed data after stream started */
 	uint64_t total_data_consumed;
 	uint64_t total_data_produced;

diff --git a/src/include/sof/audio/module_adapter/library/native_system_agent.h b/src/include/sof/audio/module_adapter/library/native_system_agent.h
@@ -20,8 +20,7 @@ struct native_system_agent {
 	uint32_t module_size;
 };
 
-void *native_system_agent_start(uint32_t *sys_service,
-				uint32_t entry_point, uint32_t module_id, uint32_t instance_id,
+void *native_system_agent_start(uint32_t entry_point, uint32_t module_id, uint32_t instance_id,
 				uint32_t core_id, uint32_t log_handle, void *mod_cfg);
 
 #endif /* __NATIVE_SYSTEM_AGENT_H__ */
diff --git a/src/library_manager/lib_manager.c b/src/library_manager/lib_manager.c
@@ -540,7 +540,7 @@ static struct comp_dev *lib_manager_module_create(const struct comp_driver *drv,
 	/* Intel modules expects DW size here */
 	mod_cfg.size = args->size >> 2;
 
-	((struct comp_driver *)drv)->adapter_ops = native_system_agent_start(NULL, module_entry_point,
+	((struct comp_driver *)drv)->adapter_ops = native_system_agent_start(module_entry_point,
 									     module_id,	instance_id,
 									     0, log_handle,
 									     &mod_cfg);