ASoC: SOF: core: Add debug module parameters to set IPC and boot timeout #5189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaluta
previously approved these changes
Sep 24, 2024
ranj063
previously approved these changes
Sep 24, 2024
bardliao
previously approved these changes
Sep 25, 2024
ranj063
reviewed
Sep 25, 2024
sound/soc/sof/core.c
Outdated
| @@ -636,11 +647,23 @@ int snd_sof_device_probe(struct device *dev, struct snd_sof_pdata *plat_data) | |||
| mutex_init(&sdev->ipc_client_mutex); | |||
| mutex_init(&sdev->client_event_handler_mutex); | |||
|
|
|||
| /* set default timeouts if none provided */ | |||
| /* set IPC timeout */ | |||
There was a problem hiding this comment.
@ujfalusi there's a checkpatch warning related to the indentation and it looks legit. Do you mind checking? Perhaps moving the new parts after the following if/else to override the default value might be better?
There was a problem hiding this comment.
@ranj063, yes, probably that is better, I'll do that.
Add two module parameters to override the IPC and boot timeout values if the SOF stack is compiled with debug enabled to allow experimenting with different timeout values without the need to recompile the kernel. Signed-off-by: Peter Ujfalusi <[email protected]>
ujfalusi
force-pushed
the
peter/sof/pr/debug-ipc-boot-timeout-01
branch
from
f8b852f
to
06ec568
Compare
|
Changes since v1:
|
plbossart
approved these changes
Sep 26, 2024
bardliao
approved these changes
Sep 26, 2024
ranj063
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two module parameters to override the IPC and boot timeout values if the SOF stack is compiled with debug enabled to allow experimenting with different timeout values without the need to recompile the kernel.