AMD SOF Soundwire generic machine driver code refactor #5171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename SoundWire endpoint and dai link structures with asoc tag to make it generic. Signed-off-by: Vijendar Mukunda <[email protected]>
Rename SoundWire parsing helper functions with 'asoc_sdw' tag to make it generic. Signed-off-by: Vijendar Mukunda <[email protected]>
Move Soundwire endpoint and dai link structures from Intel generic machine driver code to common place holder(soc_sdw_utils.h). These structures will be used in other platform SoundWire machine driver code. Signed-off-by: Vijendar Mukunda <[email protected]>
vijendarmukunda
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
bardliao and
ujfalusi
as code owners
plbossart
previously approved these changes
Sep 10, 2024
There was a problem hiding this comment.
looks ok to me but @charleskeepax and @bardliao must review
vijendarmukunda
force-pushed
the
topic/sof-dev
branch
from
6b9d6dd
to
41f67bd
Compare
|
@plbossart @bardliao @charleskeepax : could you please review ? |
charleskeepax
suggested changes
Sep 11, 2024
Move SoundWire endpoint parsing helper functions to common place holder. These functions will be used by other platform machine driver code. Signed-off-by: Vijendar Mukunda <[email protected]>
Refactor Soundwire machine driver code by using common SoundWire endpoint parsing helper functions. Signed-off-by: Vijendar Mukunda <[email protected]>
vijendarmukunda
force-pushed
the
topic/sof-dev
branch
from
41f67bd
to
b01feb3
Compare
|
@charleskeepax : dropped type strings from debug statement. There is no hard requirement to change type_strings in AMD code as of now. Changing the type_strings in driver code, also require changes in topology file. For current platform , we want to go with no modifications in type_strings for AMD source code. |
|
@bardliao : please review the PR |
charleskeepax
approved these changes
Sep 11, 2024
|
@bardliao @plbossart : as PR got approved could you please merge the PR? we have other patches to be submitted on top of it? |
tiwai
pushed a commit
to tiwai/sound
that referenced
this pull request
Sep 14, 2024
Merge series from Vijendar Mukunda <[email protected]>: This patch series moves common Soundwire endpoint parsing and dai creation logic to common placeholder from Intel generic SoundWire machine driver code to make it generic. AMD SoundWire machine driver code is refactored to use these functions for SoundWire endpoint parsing and dai creation logic. Link: thesofproject#5171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.