Naming convention change for sof_hda_dsp_generic #5163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentlu
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
bardliao and
ujfalusi
as code owners
plbossart
reviewed
Aug 30, 2024
| @@ -48,7 +48,7 @@ obj-$(CONFIG_SND_SOC_INTEL_BYT_CHT_CX2072X_MACH) += snd-soc-sst-byt-cht-cx2072x. | |||
| obj-$(CONFIG_SND_SOC_INTEL_BYT_CHT_DA7213_MACH) += snd-soc-sst-byt-cht-da7213.o | |||
| obj-$(CONFIG_SND_SOC_INTEL_BYT_CHT_ES8316_MACH) += snd-soc-sst-byt-cht-es8316.o | |||
| obj-$(CONFIG_SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH) += snd-soc-sst-byt-cht-nocodec.o | |||
| obj-$(CONFIG_SND_SOC_INTEL_SKL_HDA_DSP_GENERIC_MACH) += snd-soc-skl_hda_dsp.o | |||
| obj-$(CONFIG_SND_SOC_INTEL_SOF_HDA_DSP_GENERIC_MACH) += snd-soc-sof_hda_dsp.o | |||
There was a problem hiding this comment.
not really worth the effort, this will make backports/fixes problematic and also break CI with different module names.
There was a problem hiding this comment.
ok, let me close this PR. thanks~
Since this machine driver is no longer being used by SKL devices, we replace all 'skl' strings in driver source code with 'sof'. Signed-off-by: Brent Lu <[email protected]>
Rename source file and update makefile to follow new naming convention. Signed-off-by: Brent Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this machine driver is no longer being used by SKL devices, we replace all 'skl' strings in driver source code, makefile, and kconfig with 'sof'.