ASoC: Intel: sof_sdw_rt_sdca_jack_common: remove -sdca for new codecs #4953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bardliao
requested review from
lgirdwood,
ranj063,
kv2019i,
dbaluta and
ujfalusi
as code owners
plbossart
reviewed
Apr 25, 2024
bardliao
force-pushed
the
remove-sdca-from-components
branch
from
ed7f2d9 to
bbd2fd2
Compare
Realtek new SoundWire codecs are all -sdca version. No need to add -sdca to distinguish the non-sdca version. To be consistent with "spk:" and "mic:" components string, remove "-sdca" suffix from "hs:" components string. Signed-off-by: Bard Liao <[email protected]>
bardliao
force-pushed
the
remove-sdca-from-components
branch
from
bbd2fd2 to
165f997
Compare
ujfalusi
approved these changes
Apr 26, 2024
plbossart
approved these changes
Apr 29, 2024
plbossart
merged commit 110bdf4
into
thesofproject:topic/sof-dev
12 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realtek new SoundWire codecs are all -sdca version. No need to add -sdca to distinguish the non-sdca version. To be consistent with "spk:" and "mic:" components string, remove "-sdca" suffix from "hs:" components string.
Alternative of #4952