Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASoC: Intel: soc-acpi-intel-mtl-match: add rt713 rt1316 config #4538

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

bardliao
Copy link
Collaborator

@bardliao bardliao commented Aug 22, 2023

Adding rt713 jack + rt1316 amp + rt1713 dmic configuration support.

@bardliao bardliao requested a review from aiChaoSONG August 22, 2023 08:43
plbossart
plbossart previously approved these changes Aug 22, 2023
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can add and update later.

@bardliao
Copy link
Collaborator Author

v2 change: Move mtl_rt713_l0_rt1316_l12_rt1713_l3 upper to meet the rule that more devices need to be added first.

@bardliao
Copy link
Collaborator Author

ODM confirmed that the patch has been verified on a real device. So, it is ready for review now.

plbossart
plbossart previously approved these changes Sep 13, 2023
@bardliao
Copy link
Collaborator Author

Let's wait for some days.

@plbossart
Copy link
Member

@bardliao any reason to wait longer? if not, can @RanderWang approve?

RanderWang
RanderWang previously approved these changes Oct 10, 2023
Copy link

@RanderWang RanderWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Adding rt713 jack + rt1316 amp + rt1713 dmic configuration support.

Signed-off-by: Bard Liao <[email protected]>
@bardliao bardliao dismissed stale reviews from RanderWang and plbossart via a24228a October 11, 2023 10:44
@bardliao
Copy link
Collaborator Author

@plbossart @RanderWang
Changes: The rt1316 on link 1 is for left speaker, and the one on link 2 is for right speaker. Add a new group2 to avoid the existing configurations.

@bardliao
Copy link
Collaborator Author

@bardliao any reason to wait longer? if not, can @RanderWang approve?

We can merge this PR now. Realtek got the device and confirmed the PR works.

@plbossart plbossart requested a review from RanderWang October 11, 2023 12:48
@bardliao bardliao merged commit 347311d into thesofproject:topic/sof-dev Oct 12, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants