feat: use sessionStorage to save state of filters

[jashlu]

No description provided.

[netlify]

✅ Deploy Preview for gatsby-theme-project-portal-defaults ready!

Name	Link
🔨 Latest commit	713f80e
🔍 Latest deploy log	https://app.netlify.com/sites/gatsby-theme-project-portal-defaults/deploys/65b409aafb527500083127ee
😎 Deploy Preview	https://deploy-preview-751--gatsby-theme-project-portal-defaults.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for gatsby-theme-project-portal-ex-site ready!

Name	Link
🔨 Latest commit	713f80e
🔍 Latest deploy log	https://app.netlify.com/sites/gatsby-theme-project-portal-ex-site/deploys/65b409aa850ec90008a33196
😎 Deploy Preview	https://deploy-preview-751--gatsby-theme-project-portal-ex-site.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for project-portal-storybook ready!

Name	Link
🔨 Latest commit	713f80e
🔍 Latest deploy log	https://app.netlify.com/sites/project-portal-storybook/deploys/65b409aae89c9d000813509e
😎 Deploy Preview	https://deploy-preview-751--project-portal-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Note: This comment gets updated with every commit

Git SHA: 713f80ebd9ae8a78de64e117f64695aab8eeefe7

Site: example-site

Pa11y test status: PASS

 {
    "total": 21,
    "passes": 21,
    "errors": 0,
    "results": {
        "http://localhost:9000/project/completed-project-nodate/": [],
        "http://localhost:9000/project/completed-project/": [],
        "http://localhost:9000/project/completed-project2/": [],
        "http://localhost:9000/project/ongoing-project-nodate/": [],
        "http://localhost:9000/project/ongoing-project/": [],
        "http://localhost:9000/project/ongoing-project2/": [],
        "http://localhost:9000/project/open-project-2/": [],
        "http://localhost:9000/project/open-project-nodate/": [],
        "http://localhost:9000/project/open-project/": [],
        "http://localhost:9000/project/open-project3/": [],
        "http://localhost:9000/project/open-project4/": [],
        "http://localhost:9000/project/open-project5/": [],
        "http://localhost:9000/project/open-project6/": [],
        "http://localhost:9000/completed/": [],
        "http://localhost:9000/": [],
        "http://localhost:9000/ongoing/": [],
        "http://localhost:9000/open/": [],
        "http://localhost:9000/search/": [],
        "http://localhost:9000/about/": [],
        "http://localhost:9000/contact/": [],
        "http://localhost:9000/contact/thank-you/": []
    }
}
 

[hollandjg]

This works with the filters! Nice.

How easy would it be to include the results page number in here, so when you hit back it loads the page you were just on?

If it's easy, we could add that, if not let's make that into a separate Issue (and write down anything we know about the problem, any pitfalls we'd need to solve) and hand it over to the new keepers of the portal.

[jashlu]

This works with the filters! Nice.

How easy would it be to include the results page number in here, so when you hit back it loads the page you were just on?

If it's easy, we could add that, if not let's make that into a separate Issue (and write down anything we know about the problem, any pitfalls we'd need to solve) and hand it over to the new keepers of the portal.

Hey John, thanks for the review/comments. So this is what Heather and I have been trying to tackle recently. To summarize quickly, it's hard for us to differentiate when a projectPage is being loaded because of

1. pressing the back button and wanting to reload the state of filters/sorting, which may include different page number
2. filters/sorting applied to the project page so we want to show a fresh set of projects, starting on page 1.

This is because of the use of useEffect hooks and useState variables. I think, as you suggest, it may be better to exclude storing page in the session in this PR and get this merged in. I can put in another issue documenting the challenge with adding page number. Again, thanks for taking a look!

[hollandjg]

I can put in another issue documenting the challenge with adding page number.

That sounds great. Thanks, Josh!

[hollandjg]

This seems to me well organized and thought through. Seems to work too. Thanks!

One last thing – it looks like your reformatter didn't run:

The line breaks are a little wonky. Maybe rerun that (you might need to reconfigure your IDE) and then it should be good to go!

[hollandjg]

I reran prettier locally – I think yours was configured differently. Looks good now!

[jashlu]

I reran prettier locally – I think yours was configured differently. Looks good now!

Thank you! Merging this in.