-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add automated tests using storybook #640
Closed
hollandjg
wants to merge
19
commits into
refactor/simplify-page-layout-components
from
test/add-storybook-tests
Closed
test: add automated tests using storybook #640
hollandjg
wants to merge
19
commits into
refactor/simplify-page-layout-components
from
test/add-storybook-tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This comment gets updated with every commit 9c6d5c5b7c4b30e83c1e664ee9333a7af927555d example-site |
jashlu
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks!
…-storybook-tests # Conflicts: # package.json # packages/storybook/package.json # yarn.lock
…-storybook-tests # Conflicts: # yarn.lock
replaced by #671 (which doesn't have the same dependency chaining as this PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage existing storybook examples and test them – ensure that every example in the storybook builds without failing. (We could also include tests of each component being used if we wanted, but we don't have any yet.)