Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add automated tests using storybook #640

Conversation

hollandjg
Copy link
Contributor

@hollandjg hollandjg commented Oct 11, 2023

Leverage existing storybook examples and test them – ensure that every example in the storybook builds without failing. (We could also include tests of each component being used if we wanted, but we don't have any yet.)
Screenshot 2023-10-11 at 12 11 23

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Note: This comment gets updated with every commit

Git SHA: 9c6d5c5b7c4b30e83c1e664ee9333a7af927555d

Site: example-site

Pa11y test status: PASS

 {
    "total": 20,
    "passes": 20,
    "errors": 0,
    "results": {
        "http://localhost:9000/project/completed-project-nodate/": [],
        "http://localhost:9000/project/completed-project/": [],
        "http://localhost:9000/project/completed-project2/": [],
        "http://localhost:9000/project/ongoing-project-nodate/": [],
        "http://localhost:9000/project/ongoing-project/": [],
        "http://localhost:9000/project/ongoing-project2/": [],
        "http://localhost:9000/project/open-project-2/": [],
        "http://localhost:9000/project/open-project-nodate/": [],
        "http://localhost:9000/project/open-project/": [],
        "http://localhost:9000/project/open-project3/": [],
        "http://localhost:9000/project/open-project4/": [],
        "http://localhost:9000/project/open-project5/": [],
        "http://localhost:9000/project/open-project6/": [],
        "http://localhost:9000/completed/": [],
        "http://localhost:9000/": [],
        "http://localhost:9000/ongoing/": [],
        "http://localhost:9000/open/": [],
        "http://localhost:9000/about/": [],
        "http://localhost:9000/contact/": [],
        "http://localhost:9000/contact/thank-you/": []
    }
}
 

@hollandjg hollandjg requested review from jashlu and hetd54 October 11, 2023 15:44
@hollandjg hollandjg marked this pull request as ready for review October 11, 2023 15:44
@hollandjg hollandjg marked this pull request as draft October 11, 2023 15:45
@hollandjg hollandjg removed request for jashlu and hetd54 October 11, 2023 15:45
@hollandjg hollandjg marked this pull request as ready for review October 11, 2023 16:11
@hollandjg hollandjg requested review from jashlu and hetd54 October 11, 2023 16:11
Copy link
Contributor

@jashlu jashlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

…-storybook-tests

# Conflicts:
#	package.json
#	packages/storybook/package.json
#	yarn.lock
@hollandjg
Copy link
Contributor Author

Looks good thanks!

Thanks, Josh! This builds on #638 and #639, so I'll hang off merging until both those are through too.

@hollandjg
Copy link
Contributor Author

replaced by #671 (which doesn't have the same dependency chaining as this PR)

@hollandjg hollandjg closed this Oct 27, 2023
@hollandjg hollandjg deleted the test/add-storybook-tests branch December 5, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants