-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove additional .js files for imports #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gatsby-theme-project-portal-ex-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for project-portal-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for gatsby-theme-project-portal-defaults ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Note: This comment gets updated with every commit 4aa288bf1f275d72c3088d737f13620b6b3d0f2b example-site |
# Conflicts: # packages/gatsby-theme-project-portal/src/templates/project-detail-page.js
jashlu
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... replacing the old hack which let us get past the "createPages" bug of 2022
No idea why this actually helped, perhaps something has changed in how Gatsby handles imports since the last time we looked at this.
Example site using the updated theme code: