Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove additional .js files for imports #636

Merged
merged 18 commits into from
Oct 11, 2023

Conversation

hollandjg
Copy link
Contributor

@hollandjg hollandjg commented Oct 10, 2023

... replacing the old hack which let us get past the "createPages" bug of 2022

  • Replace template/.js files with loading directly from layout/.tsx files
  • Clean up imports
  • Update readme for packaging tests

No idea why this actually helped, perhaps something has changed in how Gatsby handles imports since the last time we looked at this.

Example site using the updated theme code:

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for gatsby-theme-project-portal-ex-site ready!

Name Link
🔨 Latest commit 4aa288b
🔍 Latest deploy log https://app.netlify.com/sites/gatsby-theme-project-portal-ex-site/deploys/6525bdfb57e9210008dcee2a
😎 Deploy Preview https://deploy-preview-636--gatsby-theme-project-portal-ex-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for project-portal-storybook ready!

Name Link
🔨 Latest commit 4aa288b
🔍 Latest deploy log https://app.netlify.com/sites/project-portal-storybook/deploys/6525bdfb83ca7c00085b70aa
😎 Deploy Preview https://deploy-preview-636--project-portal-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for gatsby-theme-project-portal-defaults ready!

Name Link
🔨 Latest commit 4aa288b
🔍 Latest deploy log https://app.netlify.com/sites/gatsby-theme-project-portal-defaults/deploys/6525bdfb33b8b20008d977f5
😎 Deploy Preview https://deploy-preview-636--gatsby-theme-project-portal-defaults.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Note: This comment gets updated with every commit

Git SHA: 4aa288bf1f275d72c3088d737f13620b6b3d0f2b

Site: example-site

Pa11y test status: PASS

 {
    "total": 20,
    "passes": 20,
    "errors": 0,
    "results": {
        "http://localhost:9000/project/completed-project-nodate/": [],
        "http://localhost:9000/project/completed-project/": [],
        "http://localhost:9000/project/ongoing-project-nodate/": [],
        "http://localhost:9000/project/ongoing-project/": [],
        "http://localhost:9000/project/ongoing-project2/": [],
        "http://localhost:9000/project/completed-project2/": [],
        "http://localhost:9000/project/open-project-2/": [],
        "http://localhost:9000/project/open-project-nodate/": [],
        "http://localhost:9000/project/open-project/": [],
        "http://localhost:9000/project/open-project4/": [],
        "http://localhost:9000/project/open-project3/": [],
        "http://localhost:9000/project/open-project5/": [],
        "http://localhost:9000/project/open-project6/": [],
        "http://localhost:9000/completed/": [],
        "http://localhost:9000/ongoing/": [],
        "http://localhost:9000/": [],
        "http://localhost:9000/open/": [],
        "http://localhost:9000/about/": [],
        "http://localhost:9000/contact/": [],
        "http://localhost:9000/contact/thank-you/": []
    }
}
 

@hollandjg hollandjg marked this pull request as ready for review October 10, 2023 19:54
# Conflicts:
#	packages/gatsby-theme-project-portal/src/templates/project-detail-page.js
@hollandjg hollandjg added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit 04be28a Oct 11, 2023
11 checks passed
@hollandjg hollandjg deleted the refactor/remove-additiona-tsx-files branch October 11, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants