This repository has been archived by the owner on Feb 13, 2019. It is now read-only.
VideoJS 5 Support #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…property checks that no longer exist
|
Can anybody help provide insight on these tests failing? I'm sure it has something to do with the plugin test suite and the new version of VideoJS and contrib-ads package, but the tests output don't get a full stack trace when an error is thrown. Even though all tests actually pass, I can determine where the issue of the error actually is. |
|
@alex-phillips |
|
@codex-corp Is there any update on this? |
|
@alex-phillips it works fine for me . |
|
I just tested this branch, on Safari i get a "black" screen and the timer stays at 5 seconds. It works in all other browsers though. Haven't tried the VideoJS 4 version of this plugin. Update: This issue only occurs if "preload='none'" on the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates allows VAST support to be used with VideoJS version 5. Some method/property checks for the
techobject were removed (no longer exist?) and the event triggers from the ad plugin have been changed in their respective projects.