Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert plugin to Vue 3 and added Typescript declaration #104

Open
wants to merge 6 commits into
base: 1.x
Choose a base branch
from

Conversation

chmking
Copy link

@chmking chmking commented May 11, 2021

This is just an update based off the changes indicated here.

I can set up a simple test case with Vue3/Vite after work. The pause feature seems to break in this case so I'll look into it.

@Jaspur
Copy link

Jaspur commented May 12, 2021

@theomessin Merge? 🙏🥺

@chmking
Copy link
Author

chmking commented May 13, 2021

@Jaspur I would consider this PR incomplete because it doesn't resolve the pause issue. If you want to use it in the incomplete state you can clone the changes locally and install via npm install <folder> I will try to fix the pause bug when I have the time.

@theomessin
Copy link
Owner

theomessin commented May 13, 2021

@Jaspur I would consider this PR incomplete because it doesn't resolve the pause issue. If you want to use it in the incomplete state you can clone the changes locally and install via npm install <folder> I will try to fix the pause bug when I have the time.

You can also try npm i git://github.com/chmking/vue-chat-scroll#next .
Or you can use the commit hash npm i git://github.com/chmking/vue-chat-scroll#1188ac24

@theomessin
Copy link
Owner

@chmking I'd probably be happy to merge this, although it'd be version 1.5.0 as I'll be introducing proper SemVer in version 2 (coming soon™)

@chmking
Copy link
Author

chmking commented May 13, 2021

@theomessin So, I've fixed the pause functionality with Vue 3.x and supported the CDN script import with examples for Vue 2.x and 3.x.
This should support backwards compat with both versions of Vue and make the 1.5.0 version more reasonable.

One thing to mention, the README is not entirely correct now. It might be worth adding documentation for both Vue versions. Thoughts?

@theomessin
Copy link
Owner

@chmking Sounds like a plan! I'll review the PR once you've added that 😄

@chmking
Copy link
Author

chmking commented May 25, 2021

@Jaspur You should already have access to the code from my branch and the method for pulling it was described. If you need it to be from the primary repo you'll need to wait until I have the time to finish up the PR. I'm very busy with work.

@chmking
Copy link
Author

chmking commented Jun 5, 2021

I think this should be sufficient for the setup instructions. Let me know if you need anything else for the PR; otherwise I'd consider this resolved and ready for merge.

@say8425
Copy link

say8425 commented Feb 17, 2022

Hello. Is there any news?

@lukasz-madon
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants