-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert plugin to Vue 3 and added Typescript declaration #104
base: 1.x
Are you sure you want to change the base?
Conversation
@theomessin Merge? 🙏🥺 |
@Jaspur I would consider this PR incomplete because it doesn't resolve the pause issue. If you want to use it in the incomplete state you can clone the changes locally and install via |
You can also try |
@theomessin So, I've fixed the pause functionality with Vue 3.x and supported the CDN script import with examples for Vue 2.x and 3.x. One thing to mention, the README is not entirely correct now. It might be worth adding documentation for both Vue versions. Thoughts? |
@chmking Sounds like a plan! I'll review the PR once you've added that 😄 |
@Jaspur You should already have access to the code from my branch and the method for pulling it was described. If you need it to be from the primary repo you'll need to wait until I have the time to finish up the PR. I'm very busy with work. |
I think this should be sufficient for the setup instructions. Let me know if you need anything else for the PR; otherwise I'd consider this resolved and ready for merge. |
Hello. Is there any news? |
LGTM |
This is just an update based off the changes indicated here.
I can set up a simple test case with Vue3/Vite after work. The pause feature seems to break in this case so I'll look into it.