-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: Replaced "tildes.net" hard-coded string. #30
base: master
Are you sure you want to change the base?
Conversation
* In python, this is accomplised by reading from the .ini setting files. * In .jinja files, this is accomplished via a global that is set up in tildes/tildes/jinja.py. If not a global, the site-name would have to be passed as a parameter to every macro that needs it. I think 'the name of the website' might be general enough to justify a global here... * One string constant needs to be formatted down-stream (tildes/lib/message.py).
I think the general approach is probably good, but I'd probably suggest:
I'll make a commit to the Tildes code that gets rid of that welcome message entirely - it's a bit outdated anyway, and should probably be done in a different way so that it's not in the code like this. |
For the first point, you're suggesting(?):
Not sure I see why we need both. I thought this change had to do with a potential domain name change for the site, not necessarily changing the name of the project. For the second point, you mean toggle off links to |
Here's the commit that removes the welcome message: spectria/tildes@a9d312d |
Have checked in Deimos's change - sorry, @interstrange, this probably breaks your change a bit. I think the site_name/domain_name split is being recommended because there's usually a difference between a website's name and a website's domain. In the case of tildes.net, it's a site named "tildes.net" that happens to be hosted on a domain called "tildes.net". But while we're hosted on themotte.org, we're not actually named "themotte.org", we're named The Motte. So we really need those to be configurable independently. And yeah, I'm not sure what the right solution regarding docs.tildes.net and blog.tildes.net is offhand. Without having looked at the code, I'd say an option to disable the main links (i.e. the bottom page links) would be good, but not try anything really extensive like, say, "leave the donation page up but disable the docs page and then programmatically go through the donation page to remove links to docs"; that's just more trouble than it's worth. Just "turn these pages off kthx". I feel like long-term this might make sense to database-ize so that admins can add or change pages within the interface, but this is something I am 100% not worrying about right now. Let me know if you're blocked on anything further :) |
Also created constants for the donate and password reset emails, which are tied to the site name.
Fixed #9