Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where appropriate, scrub references to tildes.net #9

Open
zorbathut opened this issue Jun 24, 2020 · 3 comments · May be fixed by #30
Open

Where appropriate, scrub references to tildes.net #9

zorbathut opened this issue Jun 24, 2020 · 3 comments · May be fixed by #30

Comments

@zorbathut
Copy link
Contributor

No description provided.

@interstrange
Copy link

As in, remove the string "tildes.net" where it appears? Replace it with a variable in case the top level domain changes? Replace it with something else? Can you give an example of where this would need to be scrubbed?

Thanks

@zorbathut
Copy link
Contributor Author

zorbathut commented Jul 12, 2020

I'd say, in general, that this should be turned into a variable because that's easiest for everyone long-term. I'm actually not sure how often this shows up - I just did a grep over the codebase and there's a few examples (shortener.py, settings_account_recovery.jinja2, base.jinja2) that definitely need to be fixed. Overall, I think the answer is "do a global search, ignore copyright notices, change everything that's left".

Ironically there isn't any "powered by Tildes" text anywhere because right now there's only one place it's running, which is tildes.net. So I think right now, "replaced everywhere" might be correct, ideally with a variable connected to global config.

a36f9d7 appears to be a good example of how to tie global config and page text together :)

@interstrange
Copy link

Thanks, I'll look in to this tomorrow.

@interstrange interstrange linked a pull request Jul 13, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants