chore(notice-comment): fix various copy issues #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
byhow
changed the title
byhow
changed the title
robertu7
suggested changes
May 30, 2024
lang/zh-Hans.json
Outdated
There was a problem hiding this comment.
pls correct the translations
lang/zh-Hant.json
Outdated
There was a problem hiding this comment.
please correct the translations
| @@ -27,7 +27,9 @@ const NoticeActorName = ({ | |||
| className={styles.displayName} | |||
| data-test-id={TEST_ID.NOTICE_USER_DISPLAY_NAME} | |||
| > | |||
| {user.displayName} | |||
| {user.displayName && user.displayName.length > 20 | |||
There was a problem hiding this comment.
can use MAX_USER_DISPLAY_NAME_LENGTH from utils/enums instead
also fixes PR-13 re: #4497
byhow
force-pushed
the
chore/fix-various-copy-issues
branch
from
50ea1b7 to
ce547fc
Compare
|
@robertu7 Sorry the translation bit passed through, prolly cuz I missed it after it changed after the i18n check or something. Ready for review again! |
robertu7
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #4460