Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to group object to send a value only if it was changed. #282

Closed
wants to merge 13 commits into from

Conversation

mgeramb
Copy link
Contributor

@mgeramb mgeramb commented Apr 17, 2024

Add a function to set and send a value only if it was changed. Similar to the function valueNoSentCompare the function is named valueCompare.

Waldemar Porscha and others added 10 commits January 16, 2024 00:39
- old implementation is still there for compatibility reasons
- new implementation reflects the case "uninitialized while transmitting"
- Just states "Updated", "WriteRequest" and "Ok" remove uninitialized state
…nversion by `valueNoSendCompare(..)`

* Return if Value was Changed
* Always Set the First Value
* Copy on Changes Only
* Make Comparison Independent of Sending
* Extend Doc of `valueNoSendCompare(..)`; Add Note for using `valueNoSend(..)`
custom_hwids.py was never executed in the ci pipeline, but the missing script was just a warning. With Plattform I/O Core 6.1.11 missing scripts are errors, so the pipeline fails.
# Conflicts:
#	src/knx/group_object.cpp
@mgeramb
Copy link
Contributor Author

mgeramb commented Apr 17, 2024

The build error https://github.com/thelsing/knx/actions/runs/8726457745/job/23941764455?pr=282 is not related to the change and seems to be a general issue.

@mgeramb mgeramb force-pushed the addValueCompareFunction branch from 3b78656 to a330699 Compare May 21, 2024 17:18
@mgeramb mgeramb closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants