Add KNX-IP support for the rp2040 plattform #266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9f28f8e.
Some general optimizations reagrding KNX-IP Squashed commit of the following: commit 2911448 Merge: 8ac6aec 3c29d16 Author: Dom <[email protected]> Date: Wed Dec 20 10:04:32 2023 +0100 Merge pull request #13 from OpenKNX/fix_serialnumber Fix serialnumber commit 8ac6aec Author: Ing-Dom <[email protected]> Date: Thu Dec 14 12:28:02 2023 +0100 fix macAddress reading for Wifi commit 9db2cd5 Author: Ing-Dom <[email protected]> Date: Tue Dec 12 13:08:53 2023 +0100 remove LARGE_BUFFERS and clean up header files of ETHERNET_GENERIC commit 2f229ae Author: Ing-Dom <[email protected]> Date: Tue Dec 12 00:56:32 2023 +0100 temporary fix, solution needed for tunneling commit f6e7e61 Author: Ing-Dom <[email protected]> Date: Mon Dec 11 13:54:26 2023 +0100 unified approach for different ip stacks with rp2040 plattform commit 4723eda Author: Marco Scholl <[email protected]> Date: Mon Dec 11 08:34:25 2023 +0100 wip commit 5bf3e61 Author: Ing-Dom <[email protected]> Date: Thu Dec 7 14:53:42 2023 +0100 ip and not ip in one rp2040 plattform commit aaca34a Merge: fd97f59 d44606d Author: Dom <[email protected]> Date: Wed Dec 6 15:30:17 2023 +0100 Merge branch 'thelsing:master' into rp2040_lwip commit fd97f59 Author: Marco Scholl <[email protected]> Date: Thu Nov 30 23:19:13 2023 +0100 dd sime ifdef to allow build without ip interface commit c665a79 Author: Ing-Dom <[email protected]> Date: Tue Nov 14 10:03:48 2023 +0100 stub for handling SearchRequestExt to prevent console messages commit 50745be Author: Ing-Dom <[email protected]> Date: Tue Nov 14 00:02:49 2023 +0100 adding ip support for rp2040 plattform
thelsing
reviewed
Dec 20, 2023
| default: | ||
| #ifdef KNX_LOG_IP |
There was a problem hiding this comment.
Can we not clutter the code with different LOG_THIS, LOG_THAT, LOG_SOMETHING_ELSE? If I remember correctly DEBUG should already be used in the code. If there is more granular logic needed. There could be more levels like INFO, WARN, ERR or something.
There was a problem hiding this comment.
the logging in the stack is very basic and has no levels. Its pain in the ass to debug specific stuff when you first have to comment in 100 lines.
That was the obvious, non breaking solution.
We (@traxanos and me) plan to rework this, with log levels AND specific settings that allow you to log only what you need.
|
Please separate PRs in the future and please resolve the CodeFactor issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds IP (WiFi and wired Ethernet) support to the rp2040 platform.
It includes also some optimizations for KNX-IP in general.
This PR also includes the commits from PR #265 - so it can be easily merged after that one.