-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Setting Value of Group-Object with Sending Changed Converted Value Only #258
Allow Setting Value of Group-Object with Sending Changed Converted Value Only #258
Conversation
… Bus is Triggered
Is there any reason that you marked this PR as draft? Do you still want to change something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion the forceSend argument should not be there, because there is already the value method, which clearly sends a value.
But if you add forceSend, it should be handled together with Uninitialized.
The
By handling the same way as |
Yes, the 'draft' state was intended, to have the room for optimizations, feedback (for this hopefully generically usable extension of public group-object-api) and further testing. Optimization and feedback seen yesterday. |
Replaced by #272 with checking for update only. |
Will check based on changed value after conversion.
Calling
valueModifiedSend(value, type)
with different values will only send, if value represented in given dpt is not the same.