(Prepare for devel) Fix valueNoSend: Do NOT End KO Uninitialized wh…

…en Value Conversion Failed
thelsing · Nov 2, 2024 · a7d344f · a7d344f
1 parent a42d571
commit a7d344f
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/knx/group_object/group_object.h b/src/knx/group_object/group_object.h
@@ -512,10 +512,12 @@ namespace Knx
         if (value.size() != sizeCode())
             return;
 
-        if (_uninitialized)
-            commFlag(Ok);
-
+        const bool encodingDone = true; // TODO FIXME for devel! value.encode needs success indicator
         value.encode(_data);
+
+        // initialize on succesful conversion only
+        if (encodingDone && _uninitialized)
+            commFlag(Ok);
     }
 
     template<class DPT> bool GroupObject::valueNoSendCompare(const DPT& value)