645 tfel material add eshelby tensor in anisotropic medium #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
645-tfel-material-add-eshelby-tensor-in-anisotropic-medium update 645 with master
…ed branch with master
|
Could you update the documentation and the release notes ? |
|
|
|
Do not hesitate to use the |
thelfer
reviewed
Dec 4, 2024
include/CMakeLists.txt
Outdated
Comment on lines
503
to
506
| install_header(TFEL/Material Eshelby.hxx) | ||
| install_header(TFEL/Material Eshelby.ixx) | ||
| install_header(TFEL/Material EshelbyAnisotropic.hxx) | ||
| install_header(TFEL/Material EshelbyAnisotropic.ixx) |
There was a problem hiding this comment.
Suggested change
| install_header(TFEL/Material Eshelby.hxx) | |
| install_header(TFEL/Material Eshelby.ixx) | |
| install_header(TFEL/Material EshelbyAnisotropic.hxx) | |
| install_header(TFEL/Material EshelbyAnisotropic.ixx) | |
| install_header(TFEL/Material IsotropicEshelbyLinearHomogeneization.hxx) | |
| install_header(TFEL/Material IsotropicEshelbyLinearHomogeneization.ixx) | |
| install_header(TFEL/Material AnisotropicEshelbyLinearHomogeneization.hxx) | |
| install_header(TFEL/Material AnisotropicEshelbyLinearHomogeneization.ixx) |
tests/Material/CMakeLists.txt
Outdated
| @@ -14,6 +14,7 @@ endmacro(tests_material) | |||
| tests_material(EshelbyBasedHomogenization) | |||
| tests_material(Eshelby) | |||
| tests_material(Lame) | |||
| tests_material(EshelbyAnisotropic) | |||
There was a problem hiding this comment.
See previous proposal of renaming
Comment on lines
53
to
54
| if (I > 2){fac/=std::sqrt(2);}; | ||
| if (J > 2){fac/=std::sqrt(2);}; |
There was a problem hiding this comment.
You may want to use tfel::math::Cste or constants defined in std::numbers. For instance, 1/sqrt(2) is given by:
constexpr auto icste = tfel::math::Cste<real>::isqrt2;which can be used as follows:
Suggested change
| if (I > 2){fac/=std::sqrt(2);}; | |
| if (J > 2){fac/=std::sqrt(2);}; | |
| if (I > 2){fac*=icste;}; | |
| if (J > 2){fac*=icste;}; |
Comment on lines
63
to
64
| if (I > 2){fac*=std::sqrt(2);}; | ||
| if (J > 2){fac*=std::sqrt(2);}; |
| }; | ||
|
|
||
| template<typename Type,typename real> | ||
| TFEL_HOST_DEVICE Type getStensor(const tfel::math::stensor<3u,Type>& A, int i, int j){ |
There was a problem hiding this comment.
Suggested change
| TFEL_HOST_DEVICE Type getStensor(const tfel::math::stensor<3u,Type>& A, int i, int j){ | |
| TFEL_HOST_DEVICE Type getStensorComponent(const tfel::math::stensor<3u,Type>& A, int i, int j){ |
| }; | ||
|
|
||
| template<typename Type,typename real> | ||
| TFEL_HOST_DEVICE void setStensor(tfel::math::stensor<3u,Type>& A, int i, int j,Type Aij){ |
There was a problem hiding this comment.
Suggested change
| TFEL_HOST_DEVICE void setStensor(tfel::math::stensor<3u,Type>& A, int i, int j,Type Aij){ | |
| TFEL_HOST_DEVICE void setStensorComponent(tfel::math::stensor<3u,Type>& A, int i, int j,Type Aij){ |
There was a problem hiding this comment.
In TFEL, we use unsigned short for indexing values in small objects. This is questionable, but this is how it is done.
Suggested change
| TFEL_HOST_DEVICE void setStensor(tfel::math::stensor<3u,Type>& A, int i, int j,Type Aij){ | |
| TFEL_HOST_DEVICE void setStensorComponent(tfel::math::stensor<3u,Type>& A, | |
| typename tfel::math::stensor<3u,Type>::size_type i, | |
| typename tfel::math::stensor<3u,Type>::size_type j, | |
| Type Aij){ |
| }; | ||
|
|
||
| template<typename Type,typename real> | ||
| TFEL_HOST_DEVICE void setSt4(tfel::math::st2tost2<3u,Type>& A, int i, int j, int k, int l,Type Aijkl){ |
There was a problem hiding this comment.
See the remark below for int.
Suggested change
| TFEL_HOST_DEVICE void setSt4(tfel::math::st2tost2<3u,Type>& A, int i, int j, int k, int l,Type Aijkl){ | |
| TFEL_HOST_DEVICE void setST2toST2Component(tfel::math::st2tost2<3u,Type>& A, int i, int j, int k, int l,Type Aijkl){ |
antoinecea
force-pushed
the
645-tfel-material-add-eshelby-tensor-in-anisotropic-medium
branch
from
ceaa660 to
60a2f3f
Compare
…nisotropicEshelbyTensor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eshelby and hill tensor of a 3d ellipsoid embedded in an anisotropic matrix
included : tests which show that when the matrix is isotropic, the computation coincides with the formulas already available for isotropic case
But it would be great to compare with other libraries