-
Notifications
You must be signed in to change notification settings - Fork 171
Added README template and template guide for review #248
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I leave feedback using the Conventional Comments method: https://conventionalcomments.org/
Praise: Joann, this whole template is AMAZING already! I have a few suggestions, but so much of this is really strong as it is. Very, very nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great template (and guide), very helpful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Template quality checklist
This quality checklist will eventually become a pull request template that every contributor needs to add to pull requests against the
templates
repository.Pull request summary
{Describe the purpose of your pull request.}
{Also indicate which template working group you belong to and who your template mentor is.}
Template contributor checklist
IMPORTANT: The next three sections in this checklist should be filled out by the template contributor at the time they submit this request.
NOTE: Pull requests can only be merged when all boxes are checked.
Which issue does this pull request fix or reference?
This pull request:
Procedural requirements
Template set requirements
Template pull request reviewer checklist
IMPORTANT: The rest of the sections in this checklist should only be filled out by authorized Good Docs Project pull request reviewers. If you are the individual template contributor, do not fill out the rest of the fields or check the boxes.
NOTE: Pull requests can only be merged when all boxes are checked.
Mechanics and formatting requirements - PULL REQUEST REVIEWER ONLY
Overall usability - PULL REQUEST REVIEWER ONLY
Template file requirements - PULL REQUEST REVIEWER ONLY
Template guide requirements - PULL REQUEST REVIEWER ONLY
Deep dive requirements (optional) - PULL REQUEST REVIEWER ONLY
Template example requirements (optional) - PULL REQUEST REVIEWER ONLY