fix: fix error for interfaces without ip addresses (#200)

thegeeklab · Apr 6, 2022 · fb1f93b · fb1f93b
1 parent 9968fdc
commit fb1f93b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/prometheuspvesd/discovery.py b/prometheuspvesd/discovery.py
@@ -68,7 +68,7 @@ def _get_ip_addresses(self, pve_type, pve_node, vmid):
 
             if type(networks) is list:
                 for network in networks:
-                    for ip_address in network["ip-addresses"]:
+                    for ip_address in network.get("ip-addresses", []):
                         if ip_address["ip-address-type"] == "ipv4" and not ipv4_address:
                             ipv4_address = self._validate_ip(ip_address["ip-address"])
                         elif ip_address["ip-address-type"] == "ipv6" and not ipv6_address:

diff --git a/prometheuspvesd/test/fixtures/fixtures.py b/prometheuspvesd/test/fixtures/fixtures.py
@@ -350,6 +350,10 @@ def networks():
                 "tx-packets": 14423878
             }
         },
+        {
+            "hardware-address": "ba:97:85:bd:9a:a5",
+            "name": "eth1"
+        },
     ]
-Original file line number
+Diff line change
@@ Expand Up / @@ -350,6 +350,10 @@ def networks(): @@
                     "tx-packets": 14423878
                 }
             },
+            {
+                "hardware-address": "ba:97:85:bd:9a:a5",
+                "name": "eth1"
+            },
         ]
@@ Expand Down @@