Merge pull request #347 from alodela/al/entity-ref-fix

fix(yaml-actions): Update entity by metadata name

.changeset/tough-keys-reflect.md

@@ -0,0 +1,5 @@
+---
+'@frontside/scaffolder-yaml-actions': patch
+---
+
+Support entity updates by metadata name

plugins/scaffolder-yaml-actions/src/operations/append.test.ts

@@ -15,7 +15,7 @@ describe('append', () => {
   it("creates collection when it doesn't exist", () => {
     expect(append({
       content: `metadata:
-        foo: 
+        foo:
         `,
       path: 'metadata.tags',
       value: 'production'
@@ -25,4 +25,28 @@ describe('append', () => {
     - production
 `)
   });
-});
+  it('adds to the resource entity', () => {
+    expect(append({
+      content: `metadata:
+        name: entity-a
+kind: component
+---
+metadata:
+        name: entity-b
+kind: resource
+        `,
+      path: 'metadata.tags',
+      value: 'production',
+      entityRef: 'resource:default/entity-b'
+    })).toEqual(`metadata:
+  name: entity-a
+kind: component
+---
+metadata:
+  name: entity-b
+  tags:
+    - production
+kind: resource
+`)
+  });
+});

plugins/scaffolder-yaml-actions/src/operations/append.ts

@@ -19,7 +19,7 @@ export function append({
     const maybeEntity = document.contents.toJSON();
 
     if (typeof maybeEntity.kind === 'string' &&
-      typeof maybeEntity.name === 'string' &&
+    (typeof maybeEntity.name === 'string' || typeof maybeEntity.metadata?.name === 'string') &&
       entityRef &&
       stringifyEntityRef(maybeEntity) !== entityRef) {
       continue;
@@ -43,4 +43,4 @@ export function append({
   }
 
   return documents.map(document => document.toString()).join('');
-}
+}

plugins/scaffolder-yaml-actions/src/operations/set.test.ts

@@ -22,5 +22,28 @@ describe('set', () => {
       value: 'world!!!'
     })).toBe("hello: world!!!\n")
   });
+  it('allows to set value to resource entity', () => {
+    expect(set({
+      content: `metadata:
+  name: entity-a
+kind: component
+---
+metadata:
+      name: entity-b
+kind: resource
+`,
+      path: 'hello',
+      value: 'world!!!',
+      entityRef: 'resource:default/entity-b'
+    })).toBe(`metadata:
+  name: entity-a
+kind: component
+---
+metadata:
+  name: entity-b
+kind: resource
+hello: world!!!
+`)
+  });
 });
 

plugins/scaffolder-yaml-actions/src/operations/set.ts

@@ -21,7 +21,7 @@ export function set({
     const maybeEntity = document.contents.toJSON();
 
     if (typeof maybeEntity.kind === 'string' &&
-      typeof maybeEntity.name === 'string' &&
+      (typeof maybeEntity.name === 'string' || typeof maybeEntity.metadata?.name === 'string') &&
       entityRef &&
       stringifyEntityRef(maybeEntity) !== entityRef) {
       continue;