Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n - pulling from tx #854

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Nov 28, 2023

No description provided.

@ekohl
Copy link
Member Author

ekohl commented Nov 28, 2023

Looks like CI is messed up in this repository:

Foreman::PluginRequirementError: ERF72-3740 [Foreman::PluginRequirementError]: foreman_rh_cloud plugin requires Foreman >= 3.7 but current is 3.6.2

@ekohl ekohl force-pushed the update-translations branch 2 times, most recently from c4dd650 to 01b38d5 Compare November 28, 2023 23:29
@chris1984
Copy link
Member

@ekohl can you rebase on the latest commit, I switched the container to the foreman_39 one

Since Foreman 3.7 this is required to extract strings. It sets up the
correct initializer with the correct domain for us.
The old transifex-client no longer works and transifex-client uses a
different configuration file format.
@ekohl ekohl force-pushed the update-translations branch from 01b38d5 to ce134c2 Compare December 18, 2023 11:23
@ekohl
Copy link
Member Author

ekohl commented Dec 18, 2023

Thanks for fixing CI, rebased.

@chris1984
Copy link
Member

Test failure is unrelated, have a card to fix it, merging so we can get translations in. Thanks @ekohl

@chris1984 chris1984 merged commit 03c46aa into theforeman:foreman_3_9 Dec 19, 2023
1 of 2 checks passed
@ekohl ekohl deleted the update-translations branch December 19, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants