Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #38094 - Unify inputs in convert2rhel_analyze with ForemanAnsible template #937

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Refs #38094 - Unify inputs in convert2rhel_analyze with ForemanAnsible template #937

merged 1 commit into from
Jan 10, 2025
+4 −4

Conversation

stejskalleos
Copy link
Contributor

@stejskalleos
Copy link
Contributor Author

cc @Gauravtalreja1

@stejskalleos stejskalleos marked this pull request as ready for review January 9, 2025 08:32
@stejskalleos
Copy link
Contributor Author

@adamruzicka review please

@Gauravtalreja1 Gauravtalreja1 mentioned this pull request Jan 9, 2025
Merged
2 tasks
adamruzicka
adamruzicka approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I'm too happy about this, but per-feature consistency is probably better than per-repo. Let's get this in

@adamruzicka adamruzicka merged commit 6eaee77 into theforeman:master Jan 10, 2025
21 checks passed
@adamruzicka
Copy link
Contributor

Thank you @stejskalleos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stejskalleos @adamruzicka