Fixes #38094 - Support --els switch in convert2rhel #933
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stejskalleos
changed the title
adamruzicka
requested changes
Dec 13, 2024
|
Thank you @stejskalleos ! |
Comment on lines
+8
to
+17
| template_inputs: | ||
| - name: ELS | ||
| required: true | ||
| input_type: user | ||
| description: Use an Extended Lifecycle Support (ELS) add-on subscription | ||
| advanced: false | ||
| value_type: plain | ||
| options: "true\nfalse" | ||
| default: "true" | ||
| hidden_value: false |
There was a problem hiding this comment.
After applying this patch, this option is not appearing in the inputs section on the Run Job page in UI for this job template, so just curious to know where do we define this template_inputs for UI?
| advanced: false | ||
| value_type: plain | ||
| options: "true\nfalse" | ||
| default: "true" |
There was a problem hiding this comment.
It would be default no/false, right?
| @@ -5,7 +5,20 @@ model: JobTemplate | |||
| job_category: Convert 2 RHEL | |||
| provider_type: script | |||
| kind: job_template | |||
| template_inputs: | |||
| - name: ELS | |||
| required: true | |||
There was a problem hiding this comment.
It would be required=false, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.