Fixes #38059 - job wizard limit starts at to future only #932
+79
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmalyjur
suggested changes
Dec 12, 2024
| @@ -432,7 +450,8 @@ export const JobWizard = ({ rerunData }) => { | |||
| valid.advanced && | |||
| valid.schedule && | |||
| !isSubmitting && | |||
| !isStartsBeforeError, | |||
| !isStartsBeforeError && | |||
| !isStartsAtError, | |||
There was a problem hiding this comment.
The "Next" button is enabled even when the isStartsAtError occurs.
There was a problem hiding this comment.
Thanks, added restrictions to the schedule steps
| <Alert | ||
| ouiaId="starts-at-error-alert" | ||
| variant="danger" | ||
| title={__("'Starts at' date must in the future")} |
There was a problem hiding this comment.
Missing word: "...date must be in the..."
| @@ -16,3 +16,18 @@ export const StartsBeforeErrorAlert = () => ( | |||
| <Divider component="div" /> | |||
| </> | |||
| ); | |||
|
|
|||
| export const StartsAtErrorAlert = () => ( | |||
There was a problem hiding this comment.
Maybe the file could be renamed so it's not confusing when it includes StartsAtErrorAlert now?
There was a problem hiding this comment.
Renamed to StartsErrorAlert
MariaAga
force-pushed
the
fix-start-date-jobs
branch
from
c665348 to
e9f88d1
Compare
pr-processor
bot
added
Needs re-review
and removed
Waiting on contributor
Needs re-review
labels
MariaAga
force-pushed
the
fix-start-date-jobs
branch
from
e9f88d1 to
57186da
Compare
kmalyjur
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Awesome, it can be merged - @adamruzicka can you please do it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limited most of the date pickers to be only in the future (expect the user input one).
Added an error shown when the "starts at" is in the past.
Set the default value to starts at one minute on the future.
Updated the useEffect to set errors on "future" and "recurring" schedule, and to remove them otherwise.
Since I added a timer in the useEffect I added test fixes/ adjustments.