Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37635 - HostsAndInputs.test.js missing an await #914

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

MariaAga
Copy link
Member

@MariaAga MariaAga commented Jul 8, 2024

once every 2-4 test runs the test will fail with:
Warning: An update to %s inside a test was not wrapped in act(...).
Error: Uncaught [Error: Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method
in Select (created by SearchSelect)
in SearchSelect (created by SelectGQL)
in SelectGQL (created by HostsAndInputs)
a useEffect cleanup function
in SearchSelect (created by SelectGQL)
in SelectGQL (created by HostsAndInputs)
in div (created by InputGroup)
SearchSelect
in SearchSelect (created by SelectGQL)
in SelectGQL (created by HostsAndInputs)
in div (created by InputGroup)
in InputGroup (created by HostsAndInputs)

Copy link
Contributor

@kmalyjur kmalyjur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adamruzicka adamruzicka merged commit f7f60f5 into theforeman:master Jul 9, 2024
22 of 24 checks passed
@adamruzicka
Copy link
Contributor

Thank you @MariaAga & @kmalyjur !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants