Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37677 - Extract RemWizard footer in a separate component #577

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

ofedoren
Copy link
Member

No description provided.

@adamruzicka
Copy link
Contributor

Cross posting from another channel, this fixes the footer, but the close cross button in the header seems to still have autogenerated ouia id. Is that within our control?

@ofedoren
Copy link
Member Author

Is that within our control?

Not quite. The wizard component we're using here has embedded and not changeable header subcomponent. We can hide stuff, but to add our, we'd need to write the wizard ourselves, I'm afraid.

Let's just ignore that since close cross button has the same function as cancel button.

Copy link
Member

@MariaAga MariaAga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamruzicka adamruzicka merged commit ff2bbc2 into theforeman:master Jul 30, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants