Skip to content

Commit

Permalink
Refs #37619 - Apply review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
ofedoren committed Jul 4, 2024
1 parent 411ab70 commit e249183
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/js_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ jobs:
- name: Npm install
run: |
npm install
- name: Run plugin linter
run: |
npm run lint
- name: Run custom plugin linter
run: |
npm run lint:custom
Expand Down
6 changes: 3 additions & 3 deletions webpack/components/ConfirmModal.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const ConfirmModal = props => {

const actions = [
<Button
ouiaId={`oscap-conf-modal-${props.record.id}-confirm`}
ouiaId={`oscap-conf-modal-${props.record?.id}-confirm`}
key="confirm"
variant="primary"
onClick={() => props.onConfirm(callMutation, props.record.id)}
Expand All @@ -20,7 +20,7 @@ const ConfirmModal = props => {
{__('Confirm')}
</Button>,
<Button
ouiaId={`oscap-conf-modal-${props.record.id}-cancel`}
ouiaId={`oscap-conf-modal-${props.record?.id}-cancel`}
key="cancel"
variant="link"
onClick={event => props.onClose()}
Expand All @@ -36,7 +36,7 @@ const ConfirmModal = props => {

return (
<Modal
ouiaId={`oscap-conf-modal-${props.record.id}`}
ouiaId={`oscap-conf-modal-${props.record?.id}`}
variant={ModalVariant.medium}
title={props.title}
isOpen={props.isOpen}
Expand Down

0 comments on commit e249183

Please sign in to comment.