Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some RuboCop rules #330

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Fix some RuboCop rules #330

merged 5 commits into from
Jul 16, 2024

Conversation

archanaserver
Copy link
Contributor

@archanaserver archanaserver mentioned this pull request Jun 28, 2024
Closed
12 tasks
@archanaserver
Copy link
Contributor Author

archanaserver commented Jul 12, 2024 •
edited
Loading

Hey @Manisha15 @tristanrobert, would you mind passing a review on this one? Thanks.

ehelms
ehelms approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this approved, and the changes look sane, so I am opting to go merge it.

@ehelms ehelms merged commit e1167ae into theforeman:master Jul 16, 2024
21 checks passed
@archanaserver archanaserver deleted the fix-some-cops branch July 16, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stejskalleos stejskalleos stejskalleos approved these changes

@ehelms ehelms ehelms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@archanaserver @ehelms @stejskalleos