fix: auto set vmid when creating host from Foreman API

fixes #254
theforeman · Feb 12, 2024 · 0656349 · 0656349
1 parent eb652d7
commit 0656349
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/app/models/foreman_fog_proxmox/proxmox_vm_commands.rb b/app/models/foreman_fog_proxmox/proxmox_vm_commands.rb
@@ -31,11 +31,13 @@ def start_on_boot(vm, args)
       vm
     end
 
+    # rubocop:disable Metrics/AbcSize
     def create_vm(args = {})
       vmid = args[:vmid].to_i
       type = args[:type]
       node = client.nodes.get(args[:node_id])
       vmid = node.servers.next_id.to_i if vmid < 1
+      args[:vmid] = vmid.to_s if args[:vmid].nil?
       raise ::Foreman::Exception, format(N_('invalid vmid=%<vmid>s'), vmid: vmid) unless node.servers.id_valid?(vmid)
 
       image_id = args[:image_id]
@@ -54,6 +56,7 @@ def create_vm(args = {})
       destroy_vm id.to_s + '_' + vm.vmid.to_s if vm
       raise e
     end
+    # rubocop:enable Metrics/AbcSize
 
     def compute_clone_attributes(args, container, type)
       args = parse_cloudinit_config(args) if args[:user_data]