-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use theforeman/actions for GitHub Actions configuration #75
Conversation
9595634
to
a4e2356
Compare
a4e2356
to
8403b31
Compare
@evgeni this is the only repo where I tried to also test with Foreman versions and archiving the lock files fails. I suppose the cache key isn't long enough and needs more :( |
499a71d
to
7c32178
Compare
3.8 is failing, which I think is a test setup issue, not a code issue. should we just drop it from the matrix? Edit: or pick theforeman/foreman#9932 into 3.8? |
I wonder why it even needs |
WFM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK once this is green by either
- dropping 3.8 from the matrix
- picking that puppet change into 3.8
- dropping the puppethelper from the tests
:)
now it fails on the branches that do have the helper 🙈 |
4c19ae0
to
5cf960c
Compare
5cf960c
to
8e968bc
Compare
How about conditionally including the helper? Let's see what CI says. |
That's now green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whatever works
No description provided.