Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37802 - remove unused attributes in pagination #737

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

MariaAga
Copy link
Member

Causing these errors
Warning: React does not recognize the viewType prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase viewtype instead. If you accidentally passed it from a parent component, remove it from the DOM element.
in div (created by Pagination)
in Pagination (created by Pagination)
in Pagination (created by AvailableRolesList)

printWarning @ react-dom.development.js:88Understand this error
react-dom.development.js:88 Warning: React does not recognize the dropdownButtonId prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase dropdownbuttonid instead. If you accidentally passed it from a parent component, remove it from the DOM element.
in div (created by Pagination)
in Pagination (created by Pagination)
in Pagination (created by AvailableRolesList)

Copy link

@kmalyjur kmalyjur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets rid of the errors as it should, thank you

@adamruzicka
Copy link
Contributor

@MariaAga could you please rebase so that the tests turn green?

@MariaAga
Copy link
Member Author

Thanks! rebased

@MariaAga
Copy link
Member Author

(most) tests are green, I dont think the codeclimate is related

Copy link
Contributor

@nofaralfasi nofaralfasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MariaAga!

@nofaralfasi nofaralfasi merged commit a6f5ac9 into theforeman:master Dec 16, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants