i18n - pulling from tx #731
Conversation
| msgid "Update Capsules on given hosts" | ||
| msgstr "" | ||
|
|
||
| #: ../lib/foreman_ansible/remote_execution.rb:46 | ||
| msgid "Update Capsules on given Capsule server hosts" |
There was a problem hiding this comment.
I think it's really poor practice to include downstream terminology into upstream, but it was already there so not blocking for this PR.
@adamruzicka I see you added it in c1ebb2c but should this have been added to foreman_theme_satellite?
There was a problem hiding this comment.
It's not only terminology, the whole thing is downstream specific without any sensible upstream equivalent.
While it would make sense putting downstream things into the downstream plugin, including random pieces of functionality in a branding plugin doesn't feel exactly great either.
There was a problem hiding this comment.
This whole file is messed up in terms of encoding. Looks like we missed that in 3dace0a.
Right now it's needed to update the .pot file, but something we absolutely need to fix before the next release.
|
Test failures are probably unrelated |
No description provided.