Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAT-22989 - Remove 'Run Insights maintenance plan' #712

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

stejskalleos
Copy link
Contributor

@stejskalleos stejskalleos commented Apr 17, 2024

@stejskalleos stejskalleos marked this pull request as ready for review April 17, 2024 06:44
@stejskalleos stejskalleos changed the title [WIP] SAT-22989 - Remove 'Run Insights maintenance plan' SAT-22989 - Remove 'Run Insights maintenance plan' Apr 17, 2024
@stejskalleos
Copy link
Contributor Author

I removed additional files, but I wonder if I'm not breaking anything.
@ShimShtein, can you please take a look? You know more about the Insights than I do.

@jameerpathan111 Thanks for pointing this out, I just want to let you know that the files in locale/* will be updated with the next translation sync.

Copy link
Member

@ShimShtein ShimShtein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't see any problematic code here.

@stejskalleos stejskalleos merged commit 23ca7c3 into theforeman:master Apr 25, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants