Fixes #37136 - SSH User is ignored in advanced field of job invocation #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
reviewed
Feb 9, 2024
adamruzicka
approved these changes
Feb 12, 2024
sbernhard
approved these changes
Feb 17, 2024
|
Failing tests looks unrelated. |
|
Thanks @OttaviaB @sbernhard @adamruzicka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Bug
This pull request fixes Bug #37136 - SSH User is ignored in advanced field of job invocation .
Details
The advanced field for the SSH user in the job invocation is ignored by
foreman_ansible.I fixed it so that now the priority for the SSH user is: