Fixes #37091 - Pretty print long YAML list #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Et7f3
force-pushed
the
pretty_print_yaml_list
branch
from
f7e2fb5 to
c5a9f08
Compare
Et7f3
changed the title
Et7f3
force-pushed
the
pretty_print_yaml_list
branch
from
c5a9f08 to
3993394
Compare
Et7f3
commented
Jan 24, 2024
| @@ -41,7 +40,7 @@ model: JobTemplate | |||
| <%- end -%> | |||
| tasks: | |||
| - package: | |||
| name: <%= input('name') %> | |||
| <%= indent(8) { to_yaml({"name" => input('name')}).gsub(/---\n/, '') } -%> | |||
There was a problem hiding this comment.
I was able to remove my erb loop/if pasta code. to_yaml macro doesn't seems to support :UseHeader => true https://github.com/ruby/ruby/blob/4099b04c099899d92dab3f34f1152038ed718d79/test/psych/helper.rb#L51
|
@Et7f3, I apologize for the delay. |
Et7f3
force-pushed
the
pretty_print_yaml_list
branch
from
3993394 to
2221b27
Compare
No issue it is OSS.
It was just to retrigger the CI ? I don't see conflict with it. |
|
Thanks @Et7f3! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I come after Katello/katello#10850. During testing a long list was printed for packages_name.