Fix labeler configuration for v5 #9973
Conversation
This was merged accidentally because it was green, though it was incompatible. Version 5 restructured the whole configuration file and can now label based on head or base branch names, even though we currently don't use this. Fixes: 70b2144 ("Bump actions/labeler from 4 to 5")
|
Is the "Pull Request Labeler / triage (pull_request_target)" expected to pass now? |
|
I think so, but it's not so I'll dive deeper. Or revert the bump again for now |
|
It will only pass after this has been merged to the main branch (don't ask) |
.github/workflows/labeler.yml
Outdated
| - pull_request_target | ||
| - pull_request |
There was a problem hiding this comment.
this won't work, pull_request created workflows don't have sufficient permissions to change labels (if they are created from a fork).
There was a problem hiding this comment.
Note that is from the [TMP] commit.
They may look good, but it's not working. This PR is from the repo itself and I've changed the trigger so this should be using the new config, right? |
No. It takes the config from the target. If you want the config from the PR, you need to hack more :) Edit: interestingly, https://github.com/actions/labeler#updating-major-version-of-the-labeler says it should work the way you did it… But.… Edit2: We all are a tad blind. There are two runs:
|
This was merged accidentally because it was green, though it was incompatible. Version 5 restructured the whole configuration file and can now label based on head or base branch names, even though we currently don't use this.
Contains a temporary commit to test out the config correctly.
Fixes: 70b2144 ("Bump actions/labeler from 4 to 5")