CP 3.9 Fixes #36966, #36896, #36963 UI fixes #9947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaAga
added
the
Stable branch
ekohl
approved these changes
Dec 19, 2023
ekohl
requested changes
Dec 19, 2023
|
@ekohl what are the "real commits" and where do I find them? |
ekohl
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Disregard that, I was confused by the GH UI. Somehow MariaAga@be98675 didn't show as being in develop but it really is.
Shame I didn't see this earlier (because I was on vacation) and nobody else did either. Now it missed 3.9.0 GA.
|
Ok, so I wasn't blind and those commits do indeed only live in your fork. Not in develop itself. For next time, the process is to pull the develop branch and use the commit IDs there, not from the PR you made. We should have documentation on this, but I'm not aware of any that we have today. |
|
I use your comment from here as documentation 😅 https://community.theforeman.org/t/update-stable-branch-workflows/34136/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.