Fixes #32359 - Entitlement report generation now shows all entitlements by default. #9942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts by default. Modified gitignore to exclude .yardoc directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified gitignore to exclude .yardoc directory.
This PR changes entitlement report generation via API to by default select 'no limit' in the 'Days from Now' field. This streamlines report generation in hammer, as requiring the 'Days from Now' field previously felt unnecessarily verbose. This PR also adds .yardoc/ to the gitignore; a few Phoenix members were encountering this directory and it seemed easy to just add this here.
Testing steps:
hammer report-template listto get the ids for your Foreman instance's report templates. Note the id ofSubscription - Entitlement Reportand insert where needed in the following steps.hammer report-template generate --id <id> --report-format yaml. There should be no errors.