Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36949 - Clear nav search doesn't clear results #9930

Merged
merged 1 commit into from
Dec 4, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -51,31 +51,27 @@ export const NavigationSearch = ({ items, clickAndNavigate }) => {

const onClear = () => {
setValue('');
setAutocompleteOptions(navLinksArray.slice(0, 10).map(menuNav));
};

const onChange = newValue => {
// When the value of the search input changes, build a list of no more than 10 autocomplete options.
let options = navLinksArray
.filter(({ title }) =>
title.toLowerCase().includes(newValue.toLowerCase())
)
.map(menuNav);
if (options.length > 10) {
options = options.slice(0, 10);
}

setAutocompleteOptions(options);
if (
newValue !== '' &&
searchInputRef?.current?.contains(document.activeElement)
) {
setIsAutocompleteOpen(true);

// When the value of the search input changes, build a list of no more than 10 autocomplete options.
// Options which start with the search input value are listed first, followed by options which contain
// the search input value.
let options = navLinksArray
.filter(({ title }) =>
title.toLowerCase().includes(newValue.toLowerCase())
)
.map(menuNav);
if (options.length > 10) {
options = options.slice(0, 10);
}

// The menu is hidden if there are no options
setIsAutocompleteOpen(options.length > 0);

setAutocompleteOptions(options);
} else {
setIsAutocompleteOpen(false);
}
Expand Down