Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More explicit dev setup instructions #9906

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Nov 15, 2023

This adds explicit Fedora and Enterprise Linux instructions. It also adds a section on PostgreSQL. This makes the alternative database.yml no longer needed. It also sets and explicit admin password instead of relying on the auto generated value.

Also corrects the minimum PostgreSQL version.

[source, bash]
....
dnf groupinstall "Development Tools" "Development Libraries"
dnf -y install gcc-c++ git ruby ruby-devel rubygems \
dnf -y install gcc-c++ git ruby ruby-devel rubygems-bundler \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dnf -y install gcc-c++ git ruby ruby-devel rubygems-bundler \
dnf -y install gcc-c++ git ruby ruby-devel rubygem-bundler \

....
sudo dnf install postgresql
sudo postgresql-setup --initdb
sudo -u postgres createuser --createdb $USER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to be in a specific directory to run this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that shouldn't matter. I have seen warnings when the postgres user can't chdir to $PWD, but that's only a warning.

This adds explicit Fedora and Enterprise Linux instructions. It also
adds a section on PostgreSQL. This makes the alternative database.yml
no longer needed. It also sets and explicit admin password instead of
relying on the auto generated value.
@ekohl ekohl force-pushed the correct-developer-docs branch from 5374a97 to 83e4186 Compare November 16, 2023 17:14
@stejskalleos
Copy link
Contributor

@nofaralfasi review please

Copy link
Contributor

@nofaralfasi nofaralfasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ekohl!

@stejskalleos
Copy link
Contributor

Merging is blocked by missing required checks

@ekohl ekohl merged commit 50a2b61 into theforeman:develop Feb 19, 2024
4 of 6 checks passed
@ekohl ekohl deleted the correct-developer-docs branch February 19, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants