-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #36917 - Create current user permissions API #9902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work well, couple of nitpicks though. To me this feels like the better approach over separately attaching permission-related information to data returned by api endpoints whereever we need it.
@adamruzicka thank you for the review, I just forgot to delete it. Could you please take a look at it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked together with theforeman/foreman_remote_execution#842
Thank you @kmalyjur ! |
it would be great to document the use of it somewhere, so when people write new frontend, they will not come up with some custom solution |
Creates API for getting current user permissions
Needed for theforeman/foreman_remote_execution#842