Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36917 - Create current user permissions API #9902

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fixes #36917 - Create current user permissions API #9902

merged 1 commit into from
Dec 1, 2023

Conversation

kmalyjur
Copy link
Contributor

Creates API for getting current user permissions
Needed for theforeman/foreman_remote_execution#842

Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well, couple of nitpicks though. To me this feels like the better approach over separately attaching permission-related information to data returned by api endpoints whereever we need it.

app/controllers/api/v2/permissions_controller.rb Outdated Show resolved Hide resolved
config/routes/api/v2.rb Outdated Show resolved Hide resolved
@kmalyjur
Copy link
Contributor Author

@adamruzicka thank you for the review, I just forgot to delete it. Could you please take a look at it again?

Copy link
Contributor

@pondrejk pondrejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmalyjur kmalyjur requested a review from adamruzicka November 23, 2023 09:39
@adamruzicka adamruzicka merged commit 7412115 into theforeman:develop Dec 1, 2023
9 checks passed
@adamruzicka
Copy link
Contributor

Thank you @kmalyjur !

@ares
Copy link
Member

ares commented Dec 8, 2023

it would be great to document the use of it somewhere, so when people write new frontend, they will not come up with some custom solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants