Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36915 - Correct datetime input for report generation #9901

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

sjha4
Copy link
Contributor

@sjha4 sjha4 commented Nov 13, 2023

Steps to reproduce:

  1. Go to Monitor > Report Templates > Click on Generate against any template.
  2. On the template generate form > Click the Generate at calendar icon to open input datetime calendar. The date/time overlap.
  3. Patch with this PR.
  4. On the template generate form > Click the Generate at calendar icon to open input datetime calendar. The date/time should not overlap.
  5. Upon entering some value in the field and generating report, make sure report generation task is scheduled for the selected time in foreman tasks.

@ianballou
Copy link
Contributor

[test katello]

@ianballou
Copy link
Contributor

[test]

@ianballou
Copy link
Contributor

Before:
image

After:
image

The box looks better but I'm not seeing a time picker.

@sjha4
Copy link
Contributor Author

sjha4 commented Nov 15, 2023

The box looks better but I'm not seeing a time picker.

Guessing it's a firefox thingy..

Copy link
Contributor

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

image

@ianballou ianballou merged commit c5f6770 into theforeman:develop Nov 16, 2023
12 of 14 checks passed
@MariaAga
Copy link
Member

@ianballou Please don't merge PRs with failing tests :) added a fix here: #9910

@ianballou
Copy link
Contributor

@MariaAga sorry about that, I thought it was just the rpm build that seems to usually be failing. I'll take a look at the other one.

@sjha4
Copy link
Contributor Author

sjha4 commented Nov 20, 2023

Oh I missed that failing test too..Sorry about that..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants